]> www.infradead.org Git - users/jedix/linux-maple.git/commit
mfd: ab8500-core: Return zero in get_register_interruptible()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 25 Oct 2018 12:43:44 +0000 (15:43 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 27 Feb 2019 09:08:02 +0000 (10:08 +0100)
commitc8f1d61766adeb1839eb39b04ddde5299bfc101a
tree7fc853d45d99b94e9b6220e25a37eab232b18739
parentbf0abe19df03fe398c7bc4fec954469d9ab467f0
mfd: ab8500-core: Return zero in get_register_interruptible()

[ Upstream commit 10628e3ecf544fa2e4e24f8e112d95c37884dc98 ]

This function is supposed to return zero on success or negative error
codes on error.  Unfortunately, there is a bug so it sometimes returns
non-zero, positive numbers on success.

I noticed this bug during review and I can't test it.  It does appear
that the return is sometimes propogated back to _regmap_read() where all
non-zero returns are treated as failure so this may affect run time.

Fixes: 47c1697508f2 ("mfd: Align ab8500 with the abx500 interface")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mfd/ab8500-core.c