]> www.infradead.org Git - users/dwmw2/linux.git/commit
device property: Fix the length used in PROPERTY_ENTRY_STRING()
authorHeikki Krogerus <heikki.krogerus@linux.intel.com>
Wed, 23 Jan 2019 14:44:16 +0000 (17:44 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 23 Mar 2019 19:10:04 +0000 (20:10 +0100)
commitc835b4417c18fc2868a38d4689274e3daed5c32b
treec6840d612971b33a4bfa553485e961fc797f2f8e
parent93c8a44a8297dd2b7caffeeb47e2c2256608b8ca
device property: Fix the length used in PROPERTY_ENTRY_STRING()

commit 2b6e492467c78183bb629bb0a100ea3509b615a5 upstream.

With string type property entries we need to use
sizeof(const char *) instead of the number of characters as
the length of the entry.

If the string was shorter then sizeof(const char *),
attempts to read it would have failed with -EOVERFLOW. The
problem has been hidden because all build-in string
properties have had a string longer then 8 characters until
now.

Fixes: a85f42047533 ("device property: helper macros for property entry creation")
Cc: 4.5+ <stable@vger.kernel.org> # 4.5+
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/property.h