]> www.infradead.org Git - users/dwmw2/linux.git/commit
selinux: use native iterator types
authorChristian Göttsche <cgzones@googlemail.com>
Mon, 25 Nov 2024 11:06:44 +0000 (12:06 +0100)
committerPaul Moore <paul@paul-moore.com>
Wed, 11 Dec 2024 18:54:14 +0000 (13:54 -0500)
commitc75c7945cd49c05404b00358108084a175a5fb29
treef499ebdaaa4ef1aa4097ce509a7c70b04bff4c4f
parentb01c939d5854bbf1acf6109ba7a0f74993a22b19
selinux: use native iterator types

Use types for iterators equal to the type of the to be compared values.

Reported by clang:

    ../ss/sidtab.c:126:2: warning: comparison of integers of different
                          signs: 'int' and 'unsigned long'
      126 |  hash_for_each_rcu(sidtab->context_to_sid, i, entry, list) {
          |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../hashtable.h:139:51: note: expanded from macro 'hash_for_each_rcu'
      139 |  for (... ; obj == NULL && (bkt) < HASH_SIZE(name);\
          |                             ~~~  ^ ~~~~~~~~~~~~~~~

    ../selinuxfs.c:1520:23: warning: comparison of integers of different
                            signs: 'int' and 'unsigned int'
     1520 |  for (cpu = *idx; cpu < nr_cpu_ids; ++cpu) {
          |                   ~~~ ^ ~~~~~~~~~~

    ../hooks.c:412:16: warning: comparison of integers of different signs:
                       'int' and 'unsigned long'
      412 |  for (i = 0; i < ARRAY_SIZE(tokens); i++) {
          |              ~ ^ ~~~~~~~~~~~~~~~~~~

Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
[PM: munged the clang output due to line length concerns]
Signed-off-by: Paul Moore <paul@paul-moore.com>
security/selinux/hooks.c
security/selinux/selinuxfs.c
security/selinux/ss/sidtab.c