]> www.infradead.org Git - users/dwmw2/linux.git/commit
Revert "smb: client: Fix netns refcount imbalance causing leaks and use-after-free"
authorKuniyuki Iwashima <kuniyu@amazon.com>
Wed, 2 Apr 2025 20:26:47 +0000 (13:26 -0700)
committerSteve French <stfrench@microsoft.com>
Sun, 13 Apr 2025 22:24:55 +0000 (17:24 -0500)
commitc707193a17128fae2802d10cbad7239cc57f0c95
tree1bcd86ee0d796352e87c2b8e246e175eb47242e5
parent262b73ef442e68e53220b9d6fc5a0d08b557fa42
Revert "smb: client: Fix netns refcount imbalance causing leaks and use-after-free"

This reverts commit 4e7f1644f2ac6d01dc584f6301c3b1d5aac4eaef.

The commit e9f2517a3e18 ("smb: client: fix TCP timers deadlock after
rmmod") is not only a bogus fix for LOCKDEP null-ptr-deref but also
introduces a real issue, TCP sockets leak, which will be explained in
detail in the next revert.

Also, CNA assigned CVE-2024-54680 to it but is rejecting it. [0]

Thus, we are reverting the commit and its follow-up commit 4e7f1644f2ac
("smb: client: Fix netns refcount imbalance causing leaks and
use-after-free").

Link: https://lore.kernel.org/all/2025040248-tummy-smilingly-4240@gregkh/
Fixes: 4e7f1644f2ac ("smb: client: Fix netns refcount imbalance causing leaks and use-after-free")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: stable@vger.kernel.org
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/connect.c