]> www.infradead.org Git - users/jedix/linux-maple.git/commit
xfs: remove xfs_cancel_ioend
authorDave Chinner <dchinner@redhat.com>
Mon, 15 Feb 2016 06:21:12 +0000 (17:21 +1100)
committerBrian Maly <brian.maly@oracle.com>
Wed, 18 Jul 2018 00:09:09 +0000 (20:09 -0400)
commitc680537035066177fa845053354974f7245c02d8
tree80173ec88e7e1f7dc3169b1fefd126b09edce763
parent6e2de7d4578d4f6ae76979286de5c5ee8e91754a
xfs: remove xfs_cancel_ioend

We currently have code to cancel ioends being built because we
change bufferhead state as we build the ioend. On error, this needs
to be unwound and so we have cancelling code that walks the buffers
on the ioend chain and undoes these state changes.

However, the IO submission path already handles state changes for
buffers when a submission error occurs, so we don't really need a
separate cancel function to do this - we can simply submit the
ioend chain with the specific error and it will be cancelled rather
than submitted.

Hence we can remove the explicit cancel code and just rely on
submission to deal with the error correctly.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
(cherry picked from commit 150d5be09ce49a9bed6feb7b7dc4e5ae188778ec)

Orabug: 28193043

Signed-off-by: Shan Hai <shan.hai@oracle.com>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Signed-off-by: Brian Maly <brian.maly@oracle.com>
fs/xfs/xfs_aops.c