]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/sched: revert "drm_sched_job_cleanup(): correct false doc"
authorChristian König <ckoenig.leichtzumerken@gmail.com>
Wed, 12 Mar 2025 13:44:00 +0000 (14:44 +0100)
committerPhilipp Stanner <phasta@kernel.org>
Wed, 12 Mar 2025 14:02:12 +0000 (15:02 +0100)
commitc67c0fef5d4d1b888275a588f0fb0f6f2755924b
treee8b1c2e2c2984159c48d2ac703af9e0156afbbb8
parenteff0347e7c228335e9ff64aaf02c66957803af6a
drm/sched: revert "drm_sched_job_cleanup(): correct false doc"

This reverts commit 44d2f310f008613c1dbe5e234c2cf2be90cbbfab.

The function drm_sched_job_arm() is indeed the point of no return. The
background is that it is nearly impossible for the driver to correctly
retract the fence and signal it in the order enforced by the dma_fence
framework.

The code in drm_sched_job_cleanup() is for the purpose to cleanup after
the job was armed through drm_sched_job_arm() *and* processed by the
scheduler.

We can certainly improve the documentation, but removing the warning is
clearly not a good idea.

Signed-off-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Philipp Stanner <phasta@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20250312134400.2176393-1-christian.koenig@amd.com
drivers/gpu/drm/scheduler/sched_main.c