]> www.infradead.org Git - users/jedix/linux-maple.git/commit
mm/page_alloc: avoid second trylock of zone->lock
authorAlexei Starovoitov <ast@kernel.org>
Mon, 31 Mar 2025 00:28:09 +0000 (17:28 -0700)
committerAndrew Morton <akpm@linux-foundation.org>
Sat, 12 Apr 2025 00:32:36 +0000 (17:32 -0700)
commitc5bb27e2da3a6e1006f3e0aeb36d57c1dd1144aa
treeaf7e7c3c013ab4d128954fcdd9512b465ff76ffa
parenta84edd52f0a0fa193f0f685769939cf84510755b
mm/page_alloc: avoid second trylock of zone->lock

spin_trylock followed by spin_lock will cause extra write cache access.
If the lock is contended it may cause unnecessary cache line bouncing and
will execute redundant irq restore/save pair.  Therefore, check
alloc/fpi_flags first and use spin_trylock or spin_lock.

Link: https://lkml.kernel.org/r/20250331002809.94758-1-alexei.starovoitov@gmail.com
Fixes: 97769a53f117 ("mm, bpf: Introduce try_alloc_pages() for opportunistic page allocation")
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Michal Hocko <mhocko@suse.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Reviewed-by: Harry Yoo <harry.yoo@oracle.com>
Reviewed-by: Shakeel Butt <shakeel.butt@linux.dev>
Cc: Andrii Nakryiko <andrii@kernel.org>
Cc: Daniel Borkman <daniel@iogearbox.net>
Cc: Martin KaFai Lau <martin.lau@kernel.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/page_alloc.c