]> www.infradead.org Git - users/hch/misc.git/commit
iommu/amd: Preserve default DTE fields when updating Host Page Table Root
authorAlejandro Jimenez <alejandro.j.jimenez@oracle.com>
Mon, 6 Jan 2025 19:14:13 +0000 (19:14 +0000)
committerJoerg Roedel <jroedel@suse.de>
Fri, 28 Feb 2025 11:18:00 +0000 (12:18 +0100)
commitc5b0320bbf79548fbf058a3925a07c8f281beeab
tree990e0fe9212e6ce55dd34c6d3e5181b81a79c0f7
parentd082ecbc71e9e0bf49883ee4afd435a77a5101b6
iommu/amd: Preserve default DTE fields when updating Host Page Table Root

When updating the page table root field on the DTE, avoid overwriting any
bits that are already set. The earlier call to make_clear_dte() writes
default values that all DTEs must have set (currently DTE[V]), and those
must be preserved.

Currently this doesn't cause problems since the page table root update is
the first field that is set after make_clear_dte() is called, and
DTE_FLAG_V is set again later along with the permission bits (IR/IW).
Remove this redundant assignment too.

Fixes: fd5dff9de4be ("iommu/amd: Modify set_dte_entry() to use 256-bit DTE helpers")
Signed-off-by: Alejandro Jimenez <alejandro.j.jimenez@oracle.com>
Reviewed-by: Dheeraj Kumar Srivastava <dheerajkumar.srivastava@amd.com>
Reviewed-by: Vasant Hegde <vasant.hegde@amd.com>
Link: https://lore.kernel.org/r/20250106191413.3107140-1-alejandro.j.jimenez@oracle.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/amd/iommu.c