]> www.infradead.org Git - users/jedix/linux-maple.git/commit
PCI: kirin: Fix buffer overflow in kirin_pcie_parse_port()
authorAlexandra Diupina <adiupina@astralinux.ru>
Tue, 3 Sep 2024 11:58:23 +0000 (14:58 +0300)
committerKrzysztof Wilczyński <kwilczynski@kernel.org>
Fri, 6 Sep 2024 06:36:29 +0000 (06:36 +0000)
commitc500a86693a126c9393e602741e348f80f1b0fc5
tree6daa3a78d5d9906b717b477dc83a263a4ed4f233
parent8400291e289ee6b2bf9779ff1c83a291501f017b
PCI: kirin: Fix buffer overflow in kirin_pcie_parse_port()

Within kirin_pcie_parse_port(), the pcie->num_slots is compared to
pcie->gpio_id_reset size (MAX_PCI_SLOTS) which is correct and would lead
to an overflow.

Thus, fix condition to pcie->num_slots + 1 >= MAX_PCI_SLOTS and move
pcie->num_slots increment below the if-statement to avoid out-of-bounds
array access.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: b22dbbb24571 ("PCI: kirin: Support PERST# GPIOs for HiKey970 external PEX 8606 bridge")
Link: https://lore.kernel.org/linux-pci/20240903115823.30647-1-adiupina@astralinux.ru
Signed-off-by: Alexandra Diupina <adiupina@astralinux.ru>
[kwilczynski: commit log]
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/pci/controller/dwc/pcie-kirin.c