]> www.infradead.org Git - users/jedix/linux-maple.git/commit
Input: cypress_ps2 - fix waiting for command response
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 29 Aug 2024 15:38:54 +0000 (08:38 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 29 Aug 2024 17:46:17 +0000 (10:46 -0700)
commitc472d33bcbf7a1ed3710efe93822b5e94eabe18c
treea98910a3ba4a61c9324f6da84ac1f45d107829e3
parent4e870e6bbec5c41c0d8b253282dca9465fbf5044
Input: cypress_ps2 - fix waiting for command response

Commit 8bccf667f62a ("Input: cypress_ps2 - report timeouts when reading
command status") uncovered an existing problem with cypress_ps2 driver:
it tries waiting on a PS/2 device waitqueue without using the rest of
libps2. Unfortunately without it nobody signals wakeup for the
waiting process, and each "extended" command was timing out. But the
rest of the code simply did not notice it.

Fix this by switching from homegrown way of sending request to get
command response and reading it to standard ps2_command() which does
the right thing.

Reported-by: Woody Suwalski <terraluna977@gmail.com>
Tested-by: Woody Suwalski <terraluna977@gmail.com>
Fixes: 8bccf667f62a ("Input: cypress_ps2 - report timeouts when reading command status")
Link: https://lore.kernel.org/r/a8252e0f-dab4-ef5e-2aa1-407a6f4c7204@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/mouse/cypress_ps2.c