]> www.infradead.org Git - nvme.git/commit
null_blk: fix validation of block size
authorAndreas Hindborg <a.hindborg@samsung.com>
Mon, 3 Jun 2024 19:26:45 +0000 (21:26 +0200)
committerJens Axboe <axboe@kernel.dk>
Wed, 5 Jun 2024 18:12:54 +0000 (12:12 -0600)
commitc462ecd659b5fce731f1d592285832fd6ad54053
treead4f35836996cb1a1f01421cb8b272523416813d
parent0a751df4566c86e5a24f2a03290dad3d0f215692
null_blk: fix validation of block size

Block size should be between 512 and PAGE_SIZE and be a power of 2. The current
check does not validate this, so update the check.

Without this patch, null_blk would Oops due to a null pointer deref when
loaded with bs=1536 [1].

Link: https://lore.kernel.org/all/87wmn8mocd.fsf@metaspace.dk/
Signed-off-by: Andreas Hindborg <a.hindborg@samsung.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20240603192645.977968-1-nmi@metaspace.dk
[axboe: remove unnecessary braces and != 0 check]
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/null_blk/main.c