]> www.infradead.org Git - users/jedix/linux-maple.git/commit
sched: Initialize the vruntime of a new task when it is first enqueued
authorZhang Qiao <zhangqiao22@huawei.com>
Thu, 27 Jun 2024 13:33:59 +0000 (21:33 +0800)
committerPeter Zijlstra <peterz@infradead.org>
Mon, 29 Jul 2024 10:22:34 +0000 (12:22 +0200)
commitc40dd90ac045fa1fdf6acc5bf9109a2315e6c92c
tree50c97ef495d0b4beecc16f9f6948ab03371b19bd
parentfe7a11c78d2a9bdb8b50afc278a31ac177000948
sched: Initialize the vruntime of a new task when it is first enqueued

When creating a new task, we initialize vruntime of the newly task at
sched_cgroup_fork(). However, the timing of executing this action is too
early and may not be accurate.

Because it uses current CPU to init the vruntime, but the new task
actually runs on the cpu which be assigned at wake_up_new_task().

To optimize this case, we pass ENQUEUE_INITIAL flag to activate_task()
in wake_up_new_task(), in this way, when place_entity is called in
enqueue_entity(), the vruntime of the new task will be initialized.

In addition, place_entity() in task_fork_fair() was introduced for two
reasons:
1. Previously, the __enqueue_entity() was in task_new_fair(),
in order to provide vruntime for enqueueing the newly task, the
vruntime assignment equation "se->vruntime = cfs_rq->min_vruntime" was
introduced by commit e9acbff6484d ("sched: introduce se->vruntime").
This is the initial state of place_entity().

2. commit 4d78e7b656aa ("sched: new task placement for vruntime") added
child_runs_first task placement feature which based on vruntime, this
also requires the new task's vruntime value.

After removing the child_runs_first and enqueue_entity() from
task_fork_fair(), this place_entity() no longer makes sense, so remove
it also.

Signed-off-by: Zhang Qiao <zhangqiao22@huawei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20240627133359.1370598-1-zhangqiao22@huawei.com
kernel/sched/core.c
kernel/sched/fair.c