]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ext4: validate s_reserved_gdt_blocks on mount
authorTheodore Ts'o <tytso@mit.edu>
Wed, 6 Jul 2016 00:01:52 +0000 (20:01 -0400)
committerDhaval Giani <dhaval.giani@oracle.com>
Fri, 20 Jan 2017 22:22:06 +0000 (17:22 -0500)
commitc3ed9f0f7245789cc11e21abe0fda6efbf8188d2
tree5cea9464f136f967b6752fbd54d4ff3cdfa1ef86
parent5663c9796a4169876ab64fcb3c5c756bde8bb3c5
ext4: validate s_reserved_gdt_blocks on mount

Orabug: 25308119

[ Upstream commit 5b9554dc5bf008ae7f68a52e3d7e76c0920938a2 ]

If s_reserved_gdt_blocks is extremely large, it's possible for
ext4_init_block_bitmap(), which is called when ext4 sets up an
uninitialized block bitmap, to corrupt random kernel memory.  Add the
same checks which e2fsck has --- it must never be larger than
blocksize / sizeof(__u32) --- and then add a backup check in
ext4_init_block_bitmap() in case the superblock gets modified after
the file system is mounted.

Reported-by: Vegard Nossum <vegard.nossum@oracle.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@vger.kernel.org
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
(cherry picked from commit d4d783d829cd3ade06c6b39fd7d02f00026ba699)
Signed-off-by: Dhaval Giani <dhaval.giani@oracle.com>
fs/ext4/balloc.c
fs/ext4/super.c