]> www.infradead.org Git - users/jedix/linux-maple.git/commit
nfs: nfs3acl: drop useless assignment in nfs3_get_acl()
authorSergey Shtylyov <s.shtylyov@omp.ru>
Wed, 9 Apr 2025 20:36:33 +0000 (23:36 +0300)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Mon, 28 Apr 2025 03:25:44 +0000 (23:25 -0400)
commitc367eea5041c2e5ef6836fe0ba8c5dc75a965b1b
treee21335f22d1c1f9d0b9c2cbc24b2dd132b6bfb76
parentd82e86c15364d42706eb8b5249640a839d61a681
nfs: nfs3acl: drop useless assignment in nfs3_get_acl()

In nfs3_get_acl(), the local variable status is assigned the result of
nfs_refresh_inode() inside the *switch* statement, but that value gets
overwritten in the next *if* statement's true branch and is completely
ignored if that branch isn't taken...

Found by Linux Verification Center (linuxtesting.org) with the Svace static
analysis tool.

Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Reviewed-by: Benjamin Coddington <bcodding@redhat.com>
Link: https://lore.kernel.org/r/c32dced7-a4fa-43c0-aafe-ef6c819c2f91@omp.ru
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
fs/nfs/nfs3acl.c