]> www.infradead.org Git - users/jedix/linux-maple.git/commit
btrfs: qgroup: don't use extent changeset when not needed
authorFedor Pchelkin <pchelkin@ispras.ru>
Wed, 28 Aug 2024 16:14:11 +0000 (19:14 +0300)
committerDavid Sterba <dsterba@suse.com>
Mon, 2 Sep 2024 18:18:08 +0000 (20:18 +0200)
commitc346c629765ab982967017e2ae859156d0e235cf
tree14ead1aae22a41fc1c3232d6bbe6a0fad5e06e49
parentecb54277cb63c273e8d74272e5b9bfd80c2185d9
btrfs: qgroup: don't use extent changeset when not needed

The local extent changeset is passed to clear_record_extent_bits() where
it may have some additional memory dynamically allocated for ulist. When
qgroup is disabled, the memory is leaked because in this case the
changeset is not released upon __btrfs_qgroup_release_data() return.

Since the recorded contents of the changeset are not used thereafter, just
don't pass it.

Found by Linux Verification Center (linuxtesting.org) with Syzkaller.

Reported-by: syzbot+81670362c283f3dd889c@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/lkml/000000000000aa8c0c060ade165e@google.com
Fixes: af0e2aab3b70 ("btrfs: qgroup: flush reservations during quota disable")
CC: stable@vger.kernel.org # 6.10+
Reviewed-by: Boris Burkov <boris@bur.io>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/qgroup.c