]> www.infradead.org Git - users/dwmw2/linux.git/commit
ipmi: fix oob access due to uninit smi_msg type
authorJakub Kicinski <kuba@kernel.org>
Wed, 24 Nov 2021 21:03:23 +0000 (13:03 -0800)
committerCorey Minyard <cminyard@mvista.com>
Thu, 25 Nov 2021 14:21:13 +0000 (08:21 -0600)
commitc33fdfbabb6c930454df017f3cd3507dc1a87d09
tree42323dab0427115a55c21f0d0b418672841cd802
parent5a3ba99b62d8486de0316334e72ac620d4b94fdd
ipmi: fix oob access due to uninit smi_msg type

We're hitting OOB accesses in handle_ipmb_direct_rcv_rsp() (memcpy of
size -1) after user space generates a message. Looks like the message
is incorrectly assumed to be of the new IPMB type, because type is never
set and message is allocated with kmalloc() not kzalloc().

Fixes: 059747c245f0 ("ipmi: Add support for IPMB direct messages")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Message-Id: <20211124210323.1950976-1-kuba@kernel.org>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
drivers/char/ipmi/ipmi_msghandler.c