]> www.infradead.org Git - users/dwmw2/linux.git/commit
ALSA: hda/hdmi - Read the pin sense from register when repolling
authorHui Wang <hui.wang@canonical.com>
Mon, 6 May 2019 14:09:31 +0000 (22:09 +0800)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 23 Sep 2019 20:11:59 +0000 (21:11 +0100)
commitc322ba7cd39bd986476e35edc8adc05512d9e6f1
tree696190da36869104f453bdd4000651ebeec51ff0
parent5f58860a71e06124f8b1426cf606952f35eb719a
ALSA: hda/hdmi - Read the pin sense from register when repolling

commit 8c2e6728c2bf95765b724e07d0278ae97cd1ee0d upstream.

The driver will check the monitor presence when resuming from suspend,
starting poll or interrupt triggers. In these 3 situations, the
jack_dirty will be set to 1 first, then the hda_jack.c reads the
pin_sense from register, after reading the register, the jack_dirty
will be set to 0. But hdmi_repoll_work() is enabled in these 3
situations, It will read the pin_sense a couple of times subsequently,
since the jack_dirty is 0 now, It does not read the register anymore,
instead it uses the shadow pin_sense which is read at the first time.

It is meaningless to check the shadow pin_sense a couple of times,
we need to read the register to check the real plugging state, so
we set the jack_dirty to 1 in the hdmi_repoll_work().

Signed-off-by: Hui Wang <hui.wang@canonical.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
sound/pci/hda/patch_hdmi.c