]> www.infradead.org Git - users/hch/block.git/commit
block: Drop locking annotation for limits_lock
authorJohn Garry <john.g.garry@oracle.com>
Fri, 14 Jun 2024 09:03:44 +0000 (09:03 +0000)
committerJens Axboe <axboe@kernel.dk>
Sun, 16 Jun 2024 21:30:26 +0000 (15:30 -0600)
commitc3042a5403ef2be622023fcc3b11fc1aa08ba7fa
treeb30fd36fd7e8d144b1cc1914cd7499e05f3fee44
parentd9c2332199d073c5edd7163d64fbdee6224d8c08
block: Drop locking annotation for limits_lock

Currently compiling block/blk-settings.c with C=1 gives the following
warning:
block/blk-settings.c:262:9: warning: context imbalance in 'queue_limits_commit_update' - wrong count at exit

request_queue.limits_lock is a mutex. Sparse locking annotation for
mutexes are currently not supported - see [0] - so drop that locking
annotation.

[0] https://lore.kernel.org/lkml/cover.1579893447.git.jbi.octave@gmail.com/T/#mbb8bda6c0a7ca7ce19f46df976a8e3b489745488

Fixes: d690cb8ae14bd ("block: add an API to atomically update queue limits")
Signed-off-by: John Garry <john.g.garry@oracle.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20240614090345.655716-3-john.g.garry@oracle.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-settings.c
include/linux/blkdev.h