]> www.infradead.org Git - users/jedix/linux-maple.git/commit
mm: memcg: adjust the warning when seq_buf overflows
authorXiu Jianfeng <xiujianfeng@huawei.com>
Fri, 28 Jun 2024 07:23:33 +0000 (07:23 +0000)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 5 Jul 2024 01:05:59 +0000 (18:05 -0700)
commitc2fad56b3c12a5fc6ea7426d2e39459e85e5b55e
tree4939d27cf644df8d973ba2658b213e2171869733
parent1c46cc09896f3c2a896c152bcfb8c2987810fde5
mm: memcg: adjust the warning when seq_buf overflows

Currently it uses WARN_ON_ONCE() if seq_buf overflows when user reads
memory.stat, the only advantage of WARN_ON_ONCE is that the splat is so
verbose that it gets noticed.  And also it panics the system if
panic_on_warn is enabled.  It seems like the warning is just an over
reaction and a simple pr_warn should just achieve the similar effect.

Link: https://lkml.kernel.org/r/20240628072333.2496527-1-xiujianfeng@huawei.com
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Suggested-by: Michal Hocko <mhocko@suse.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Muchun Song <muchun.song@linux.dev>
Cc: Roman Gushchin <roman.gushchin@linux.dev>
Cc: Shakeel Butt <shakeel.butt@linux.dev>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/memcontrol.c