]> www.infradead.org Git - users/jedix/linux-maple.git/commit
mmc: sdhci-msm: Fix error handling for dev_pm_opp_of_add_table()
authorRajendra Nayak <rnayak@codeaurora.org>
Tue, 28 Apr 2020 13:32:57 +0000 (19:02 +0530)
committerUlf Hansson <ulf.hansson@linaro.org>
Thu, 28 May 2020 09:21:02 +0000 (11:21 +0200)
commitc2b613d03b060993be71b480a3ebb6156604d658
tree43d9686fae0f902ad65bcb313998de4feff26f53
parenta38c078fea0b1393fd2acb50e91057d7e429d9aa
mmc: sdhci-msm: Fix error handling for dev_pm_opp_of_add_table()

Even though specifying OPP's in device tree is optional, ignoring all errors
reported by dev_pm_opp_of_add_table() means we can't distinguish between a
missing OPP table and a wrong/buggy OPP table. While missing OPP table
(dev_pm_opp_of_add_table() returns a -ENODEV in such case) can be ignored,
a wrong/buggy OPP table in device tree should make the driver error out.

while we fix that, lets also fix the variable names for opp/opp_table to
avoid confusion and name them opp_table/has_opp_table instead.

Suggested-by: Matthias Kaehlcke <matthias@chromium.org>
Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
Link: https://lore.kernel.org/r/1588080785-6812-10-git-send-email-rnayak@codeaurora.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci-msm.c