]> www.infradead.org Git - users/willy/xarray.git/commit
power: supply: cros_charge-control: hide start threshold on v2 cmd
authorThomas Weißschuh <linux@weissschuh.net>
Sun, 8 Dec 2024 14:59:28 +0000 (15:59 +0100)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Tue, 10 Dec 2024 01:51:45 +0000 (02:51 +0100)
commitc28dc9fc24f5fa802d44ef7620a511035bdd803e
tree64ae16360ba992b9966d0a3b04d44e4f442e5c03
parente65a1b7fad0e112573eea7d64d4ab4fc513b8695
power: supply: cros_charge-control: hide start threshold on v2 cmd

ECs implementing the v2 command will not stop charging when the end
threshold is reached. Instead they will begin discharging until the
start threshold is reached, leading to permanent charge and discharge
cycles. This defeats the point of the charge control mechanism.

Avoid the issue by hiding the start threshold on v2 systems.
Instead on those systems program the EC with start == end which forces
the EC to reach and stay at that level.

v1 does not support thresholds and v3 works correctly,
at least judging from the code.

Reported-by: Thomas Koch <linrunner@gmx.net>
Fixes: c6ed48ef5259 ("power: supply: add ChromeOS EC based charge control driver")
Cc: stable@vger.kernel.org
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Link: https://lore.kernel.org/r/20241208-cros_charge-control-v2-v1-3-8d168d0f08a3@weissschuh.net
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/cros_charge-control.c