]> www.infradead.org Git - users/willy/pagecache.git/commit
fs/pipe: Fix pipe_occupancy() with 16-bit indexes
authorLinus Torvalds <torvalds@linux-foundation.org>
Wed, 5 Mar 2025 17:08:09 +0000 (07:08 -1000)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 5 Mar 2025 17:08:09 +0000 (07:08 -1000)
commitc27c66afc449b80f3b4b84d123358c0248f2cf63
treeaa8b693bfec51b1933df6415b7c8da7f7966d799
parentbb2281fb05e50108ce95c43ab7e701ee564565c8
fs/pipe: Fix pipe_occupancy() with 16-bit indexes

The pipe_occupancy() logic implicitly relied on the natural unsigned
modulo arithmetic in C, but that doesn't work for the new 'pipe_index_t'
case, since any arithmetic will be done in 'int' (and here we had also
made it 'unsigned int' due to the function call boundary).

So make the modulo arithmetic explicit by casting the result to the
proper type.

Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Mateusz Guzik <mjguzik@gmail.com>
Cc: Manfred Spraul <manfred@colorfullife.com>
Cc: Christian Brauner <brauner@kernel.org>
Cc: Swapnil Sapkal <swapnil.sapkal@amd.com>
Cc: Alexey Gladkov <legion@kernel.org>
Cc: K Prateek Nayak <kprateek.nayak@amd.com>
Link: https://lore.kernel.org/all/CAHk-=wjyHsGLx=rxg6PKYBNkPYAejgo7=CbyL3=HGLZLsAaJFQ@mail.gmail.com/
Fixes: 3d252160b818 ("fs/pipe: Read pipe->{head,tail} atomically outside pipe->mutex")
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
include/linux/pipe_fs_i.h