]> www.infradead.org Git - users/jedix/linux-maple.git/commit
usbnet: ipheth: fix possible overflow in DPE length check
authorFoster Snowhill <forst@pen.gy>
Sat, 25 Jan 2025 23:54:03 +0000 (00:54 +0100)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 28 Jan 2025 11:16:32 +0000 (12:16 +0100)
commitc219427ed296f94bb4b91d08626776dc7719ee27
treea5f952016643e1a57dad9c8500671a85b4eb4502
parent19ae40f572a9ce1ade9954990af709a03fd37010
usbnet: ipheth: fix possible overflow in DPE length check

Originally, it was possible for the DPE length check to overflow if
wDatagramIndex + wDatagramLength > U16_MAX. This could lead to an OoB
read.

Move the wDatagramIndex term to the other side of the inequality.

An existing condition ensures that wDatagramIndex < urb->actual_length.

Fixes: a2d274c62e44 ("usbnet: ipheth: add CDC NCM support")
Cc: stable@vger.kernel.org
Signed-off-by: Foster Snowhill <forst@pen.gy>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/usb/ipheth.c