]> www.infradead.org Git - users/jedix/linux-maple.git/commit
KVM: x86: Retry to-be-emulated insn in "slow" unprotect path iff sp is zapped
authorSean Christopherson <seanjc@google.com>
Sat, 31 Aug 2024 00:15:20 +0000 (17:15 -0700)
committerSean Christopherson <seanjc@google.com>
Tue, 10 Sep 2024 03:16:21 +0000 (20:16 -0700)
commitc1edcc41c3603c65f34000ae031a20971f4e56f9
tree44582acd0edcc0a583b23c0966df47ec2bdce233
parent2fb2b7877b3a4cac4de070ef92437b38f13559b0
KVM: x86: Retry to-be-emulated insn in "slow" unprotect path iff sp is zapped

Resume the guest and thus skip emulation of a non-PTE-writing instruction
if and only if unprotecting the gfn actually zapped at least one shadow
page.  If the gfn is write-protected for some reason other than shadow
paging, attempting to unprotect the gfn will effectively fail, and thus
retrying the instruction is all but guaranteed to be pointless.  This bug
has existed for a long time, but was effectively fudged around by the
retry RIP+address anti-loop detection.

Reviewed-by: Yuan Yao <yuan.yao@intel.com>
Link: https://lore.kernel.org/r/20240831001538.336683-6-seanjc@google.com
Signed-off-by: Sean Christopherson <seanjc@google.com>
arch/x86/kvm/x86.c