]> www.infradead.org Git - users/jedix/linux-maple.git/commit
rds: fix an integer overflow test in rds_info_getsockopt()
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 1 Aug 2015 12:33:26 +0000 (15:33 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 29 Sep 2015 17:26:25 +0000 (19:26 +0200)
commitc1a6ce0483bbdd9cf3489ef9efc312482344f58c
tree635a77d68524d6e8fe0b49c16d4d45f4002b577c
parent715bb7ae43279e24a8d4d35a9ac8288b47a75500
rds: fix an integer overflow test in rds_info_getsockopt()

[ Upstream commit 468b732b6f76b138c0926eadf38ac88467dcd271 ]

"len" is a signed integer.  We check that len is not negative, so it
goes from zero to INT_MAX.  PAGE_SIZE is unsigned long so the comparison
is type promoted to unsigned long.  ULONG_MAX - 4095 is a higher than
INT_MAX so the condition can never be true.

I don't know if this is harmful but it seems safe to limit "len" to
INT_MAX - 4095.

Fixes: a8c879a7ee98 ('RDS: Info and stats')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/rds/info.c