]> www.infradead.org Git - users/dwmw2/linux.git/commit
sctp: sysctl: udp_port: avoid using current->nsproxy
authorMatthieu Baerts (NGI0) <matttbe@kernel.org>
Wed, 8 Jan 2025 15:34:35 +0000 (16:34 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 9 Jan 2025 16:53:35 +0000 (08:53 -0800)
commitc10377bbc1972d858eaf0ab366a311b39f8ef1b6
treeb8e7cf4cc508fad32d8edd12827d9e7dc3aa0455
parent15649fd5415eda664ef35780c2013adeb5d9c695
sctp: sysctl: udp_port: avoid using current->nsproxy

As mentioned in a previous commit of this series, using the 'net'
structure via 'current' is not recommended for different reasons:

- Inconsistency: getting info from the reader's/writer's netns vs only
  from the opener's netns.

- current->nsproxy can be NULL in some cases, resulting in an 'Oops'
  (null-ptr-deref), e.g. when the current task is exiting, as spotted by
  syzbot [1] using acct(2).

The 'net' structure can be obtained from the table->data using
container_of().

Note that table->data could also be used directly, but that would
increase the size of this fix, while 'sctp.ctl_sock' still needs to be
retrieved from 'net' structure.

Fixes: 046c052b475e ("sctp: enable udp tunneling socks")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/67769ecb.050a0220.3a8527.003f.GAE@google.com
Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20250108-net-sysctl-current-nsproxy-v1-7-5df34b2083e8@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/sctp/sysctl.c