]> www.infradead.org Git - users/willy/xarray.git/commit
phy: core: Fix that API devm_of_phy_provider_unregister() fails to unregister the...
authorZijun Hu <quic_zijuhu@quicinc.com>
Fri, 13 Dec 2024 12:36:42 +0000 (20:36 +0800)
committerVinod Koul <vkoul@kernel.org>
Tue, 24 Dec 2024 14:25:37 +0000 (19:55 +0530)
commitc0b82ab95b4f1fbc3e3aeab9d829d012669524b6
treeb93bf7e5977389e50d59dd360436cc4126d457dd
parentfe4bfa9b6d7bd752bfe4700c937f235aa8ce997b
phy: core: Fix that API devm_of_phy_provider_unregister() fails to unregister the phy provider

For devm_of_phy_provider_unregister(), its comment says it needs to invoke
of_phy_provider_unregister() to unregister the phy provider, but it will
not actually invoke the function since devres_destroy() does not call
devm_phy_provider_release(), and the missing of_phy_provider_unregister()
call will cause:

- The phy provider fails to be unregistered.
- Leak both memory and the OF node refcount.

Fortunately, the faulty API has not been used by current kernel tree.
Fix by using devres_release() instead of devres_destroy() within the API.

Fixes: ff764963479a ("drivers: phy: add generic PHY framework")
Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/stable/20241213-phy_core_fix-v6-2-40ae28f5015a%40quicinc.com
Link: https://lore.kernel.org/r/20241213-phy_core_fix-v6-2-40ae28f5015a@quicinc.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/phy-core.c