]> www.infradead.org Git - users/jedix/linux-maple.git/commit
xfrm: replay: Fix the update of replay_esn->oseq_hi for GSO
authorJianbo Liu <jianbol@nvidia.com>
Tue, 12 Nov 2024 12:10:31 +0000 (14:10 +0200)
committerSteffen Klassert <steffen.klassert@secunet.com>
Mon, 25 Nov 2024 07:32:40 +0000 (08:32 +0100)
commitc05c5e5aa163f4682ca97a2f0536575fc7dbdecb
treec772adaa4a00be81426b7bba3be5afad0dd5c6be
parent9bb88c659673003453fd42e0ddf95c9628409094
xfrm: replay: Fix the update of replay_esn->oseq_hi for GSO

When skb needs GSO and wrap around happens, if xo->seq.low (seqno of
the first skb segment) is before the last seq number but oseq (seqno
of the last segment) is after it, xo->seq.low is still bigger than
replay_esn->oseq while oseq is smaller than it, so the update of
replay_esn->oseq_hi is missed for this case wrap around because of
the change in the cited commit.

For example, if sending a packet with gso_segs=3 while old
replay_esn->oseq=0xfffffffe, we calculate:
    xo->seq.low = 0xfffffffe + 1 = 0x0xffffffff
    oseq = 0xfffffffe + 3 = 0x1
(oseq < replay_esn->oseq) is true, but (xo->seq.low <
replay_esn->oseq) is false, so replay_esn->oseq_hi is not incremented.

To fix this issue, change the outer checking back for the update of
replay_esn->oseq_hi. And add new checking inside for the update of
packet's oseq_hi.

Fixes: 4b549ccce941 ("xfrm: replay: Fix ESN wrap around for GSO")
Signed-off-by: Jianbo Liu <jianbol@nvidia.com>
Reviewed-by: Patrisious Haddad <phaddad@nvidia.com>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
net/xfrm/xfrm_replay.c