]> www.infradead.org Git - users/jedix/linux-maple.git/commit
SPARC64: ds driver: Make memory allocations ATOMIC and enhance debugging
authorAaron Young <Aaron.Young@oracle.com>
Wed, 23 Nov 2016 16:02:02 +0000 (11:02 -0500)
committerAllen Pais <allen.pais@oracle.com>
Sun, 22 Jan 2017 15:38:37 +0000 (21:08 +0530)
commitc0250ff46f5e98131d742395438c2f18fe09eb7c
tree45d7aef96a1d418b155a130c70488d988c7b9da7
parent6fb5f7a58bbc90dc5500496e93dbe2f707fd4cb9
SPARC64: ds driver: Make memory allocations ATOMIC and enhance debugging

This patch fixes the following issues:

1. BUG 25107317 - Kernel Panic: Watchdog HARD LOCKUP out of ds_cap_fini()
2. BUG 24787856 - Forward port 19811909 - Unnecessary
                  warning - ldom_req_sp_token

BUG 25107317 appears to be caused by the ds driver allocating memory using
the GFP_KERNEL flag (which can result in sleeping) while holding a spinlock.
This is a violation of rules and resulted in the panic.

To fix BUG 24787856, the error message in question was changed to a
printk_once() which will result in the message only appearing once
in the console log instead of repeatedly.

The debugging facility in the driver was also enhanced by adding 3 separate
debug levels for the ds driver debug messages.

Signed-off-by: Aaron Young <Aaron.Young@oracle.com>
Reviewed-by: Alexandre Chartre <Alexandre.Chartre@oracle.com>
Reviewed-By: Liam Merwick <Liam.Merwick@oracle.com>
Orabug: 2510731724787856
(cherry picked from commit f3bf272f0512120708a2966a7916b51c34efe56d)
Signed-off-by: Allen Pais <allen.pais@oracle.com>
arch/sparc/kernel/ds.c