]> www.infradead.org Git - mtd-utils.git/commit
jffsX-utils: fix integer overflow in jffs2dump.c
authorAnton Moryakov <ant.v.moryakov@gmail.com>
Tue, 24 Dec 2024 12:27:09 +0000 (15:27 +0300)
committerDavid Oberhollenzer <david.oberhollenzer@sigma-star.at>
Tue, 24 Dec 2024 16:22:12 +0000 (17:22 +0100)
commitc01a38b3441b7a638137aa99c4ddd410a8dc4468
tree4e1698f3df21873d1017e7ab2d2988ad5f938fc9
parent117efd252bc485084a609c405c312f5a9229e25a
jffsX-utils: fix integer overflow in jffs2dump.c

Report of the static analyzer:
The value of an arithmetic expression 'datsize + oobsize' is a subject to overflow because its operands are not cast to a larger data type before performing arithmetic.

Corrections explained:
- Added a check to validate datsize and oobsize to ensure they are non-negative and within a safe range.
- Cast datsize and oobsize to long before performing arithmetic to prevent potential integer overflow.

This change ensures safe computation of offsets and prevents undefined behavior caused by overflow.

Signed-off-by: Anton Moryakov <ant.v.moryakov@gmail.com>
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
jffsX-utils/jffs2dump.c