]> www.infradead.org Git - users/dwmw2/linux.git/commit
drm/vc4: hdmi: Don't access the connector state in reset if kmalloc fails
authorMaxime Ripard <maxime@cerno.tech>
Tue, 15 Dec 2020 15:42:38 +0000 (16:42 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 21 Aug 2022 13:15:43 +0000 (15:15 +0200)
commitc015d12317c503dff7fc8f20a6ae00be255cb1a3
tree158b7994c0c050f7de168b4cc36a1ab030598773
parentba8ffdb450d4371b49e98282b4c4416836addd26
drm/vc4: hdmi: Don't access the connector state in reset if kmalloc fails

[ Upstream commit e55a07751146ef8ebc2c561564437b78f46405d3 ]

drm_atomic_helper_connector_reset uses kmalloc which, from an API
standpoint, can fail, and thus setting connector->state to NULL.
However, our reset hook then calls drm_atomic_helper_connector_tv_reset
that will access connector->state without checking if it's a valid
pointer or not.

Make sure we don't end up accessing a NULL pointer.

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Suggested-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20201215154243.540115-5-maxime@cerno.tech
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/vc4/vc4_hdmi.c