]> www.infradead.org Git - users/dwmw2/linux.git/commit
mac802154: Fix potential RCU dereference issue in mac802154_scan_worker
authorJiawei Ye <jiawei.ye@foxmail.com>
Tue, 24 Sep 2024 06:58:05 +0000 (06:58 +0000)
committerStefan Schmidt <stefan@datenfreihafen.org>
Tue, 24 Sep 2024 09:53:50 +0000 (11:53 +0200)
commitbff1709b3980bd7f80be6786f64cc9a9ee9e56da
tree7d65a1ae23cec2f906c95552937a57aa76243eeb
parentaddf89774e48c992316449ffab4f29c2309ebefb
mac802154: Fix potential RCU dereference issue in mac802154_scan_worker

In the `mac802154_scan_worker` function, the `scan_req->type` field was
accessed after the RCU read-side critical section was unlocked. According
to RCU usage rules, this is illegal and can lead to unpredictable
behavior, such as accessing memory that has been updated or causing
use-after-free issues.

This possible bug was identified using a static analysis tool developed
by myself, specifically designed to detect RCU-related issues.

To address this, the `scan_req->type` value is now stored in a local
variable `scan_req_type` while still within the RCU read-side critical
section. The `scan_req_type` is then used after the RCU lock is released,
ensuring that the type value is safely accessed without violating RCU
rules.

Fixes: e2c3e6f53a7a ("mac802154: Handle active scanning")
Cc: stable@vger.kernel.org
Signed-off-by: Jiawei Ye <jiawei.ye@foxmail.com>
Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Link: https://lore.kernel.org/tencent_3B2F4F2B4DA30FAE2F51A9634A16B3AD4908@qq.com
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
net/mac802154/scan.c