]> www.infradead.org Git - linux.git/commit
arm64: dts: rockchip: Add dma-names to uart1 on quartz64-b
authorDiederik de Haas <didi.debian@cknow.org>
Fri, 28 Jun 2024 12:00:43 +0000 (14:00 +0200)
committerHeiko Stuebner <heiko@sntech.de>
Thu, 4 Jul 2024 17:56:46 +0000 (19:56 +0200)
commitbf6f26deb0e84089700c1b864f643442e262e16b
treef4bc24d0ad069c6d553172fa610fd25993bef6ac
parenteb665b1c06bcaf16df10018550d8f467ed4b2887
arm64: dts: rockchip: Add dma-names to uart1 on quartz64-b

There have been several attempts to set the dma-names property on the
SoC level (in rk356x.dtsi), but that appears to cause problems when set
on channels without flow control.

Quoting part of a previous attempt for clarification:

> Nah, enabling it for bluetooth is fine because you have flow control.
> My issues have been on channels without flow control. Without DMA it
> simply drops messages or the channel hangs until you close and reopen
> it. With DMA, when an overflow locks up the channel it is usually
> unavailable until the board is rebooted.

Setting it on the board level for the bluetooth connection was deemed
safe, so do so for the Quartz64 Model B.

This fixes the following error/warning:

  of_dma_request_slave_channel: dma-names property of node
      '/serial@fe650000' missing or empty
  dw-apb-uart fe650000.serial: failed to request DMA

Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
Link: https://libera.irclog.whitequark.org/armlinux/2024-02-29
Link: https://lore.kernel.org/linux-rockchip/18284546.sWSEgdgrri@diego/
Reviewed-by: Dragan Simic <dsimic@manjaro.org>
Link: https://lore.kernel.org/r/20240628120130.24076-1-didi.debian@cknow.org
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts