]> www.infradead.org Git - users/willy/xarray.git/commit
iommu/arm-smmu-v3: Fix incorrect return in arm_smmu_attach_dev
authorQinxin Xia <xiaqinxin@huawei.com>
Tue, 22 Apr 2025 11:29:51 +0000 (19:29 +0800)
committerWill Deacon <will@kernel.org>
Tue, 6 May 2025 12:45:49 +0000 (13:45 +0100)
commitbe5a2d3f8f9738ea1426e7d2243707164ed5bac2
treebe3b4a8f2f6e8407d9f085dda1ecd30693dc1d20
parent8ffd015db85fea3e15a77027fda6c02ced4d2444
iommu/arm-smmu-v3: Fix incorrect return in arm_smmu_attach_dev

After commit 48e7b8e284e5 ("iommu/arm-smmu-v3: Remove
arm_smmu_domain_finalise() during attach"), an error code is not
returned on the attach path when the smmu does not match with the
domain. This causes problems with VFIO because
vfio_iommu_type1_attach_group() relies on this check to determine domain
compatability.

Re-instate the -EINVAL return value when the SMMU doesn't match on the
device attach path.

Fixes: 48e7b8e284e5 ("iommu/arm-smmu-v3: Remove arm_smmu_domain_finalise() during attach")
Signed-off-by: Qinxin Xia <xiaqinxin@huawei.com>
Link: https://lore.kernel.org/r/20250422112951.2027969-1-xiaqinxin@huawei.com
Signed-off-by: Will Deacon <will@kernel.org>
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c