]> www.infradead.org Git - users/jedix/linux-maple.git/commit
wifi: rtw89: 8852bt: rfk: use predefined string choice for DPK enable/disable
authorPing-Ke Shih <pkshih@realtek.com>
Sat, 20 Jul 2024 02:13:35 +0000 (10:13 +0800)
committerPing-Ke Shih <pkshih@realtek.com>
Wed, 31 Jul 2024 05:48:08 +0000 (13:48 +0800)
commitbe457fbacea9fdceb1dbeb8034eaee9713962c06
tree30489154c5f3ecec5e8bcae351c819062b39c7e0
parent6bd63e44e98e06efebc89c5b606259bf2fd8f96c
wifi: rtw89: 8852bt: rfk: use predefined string choice for DPK enable/disable

clang warns precedence of '?:' and '&'. Even though original logic is
correct, use str_enable_disable() to avoid clang confusing. Another way to
fix is to add parentheses around '&', but I choose former one.

  >> drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c:1827:46: warning:
     operator '?:' has lower precedence than '&'; '&' will be evaluated
     first [-Wbitwise-conditional-parentheses]
    1827 |                     kidx, dpk->is_dpk_enable & off_reverse ? "enable" : "disable");
         |                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202407200741.dMG9uvHU-lkp@intel.com/
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/20240720021340.12102-3-pkshih@realtek.com
drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c