]> www.infradead.org Git - users/jedix/linux-maple.git/commit
cpufreq: CPPC: Fix wrong return value in cppc_get_cpu_cost()
authorJinjie Ruan <ruanjinjie@huawei.com>
Wed, 6 Nov 2024 01:12:38 +0000 (09:12 +0800)
committerViresh Kumar <viresh.kumar@linaro.org>
Mon, 11 Nov 2024 04:15:16 +0000 (09:45 +0530)
commitbe392aa80f1e5b0b65ccc2a540b9304fefcfe3d8
treedc22e932d6165adca1def9547ce5adb35ea46066
parentdb01e46689e9a986ca6b5d2f41b57d7a81551a4f
cpufreq: CPPC: Fix wrong return value in cppc_get_cpu_cost()

cppc_get_cpu_cost() return 0 if the policy is NULL. Then in
em_compute_costs(), the later zero check for cost is not valid
as cost is uninitialized. As Quentin pointed out, kernel energy model
core check the return value of get_cost() first, so if the callback
failed it should tell the core. Return -EINVAL to fix it.

Fixes: 1a1374bb8c59 ("cpufreq: CPPC: Fix possible null-ptr-deref for cppc_get_cpu_cost()")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/c4765377-7830-44c2-84fa-706b6e304e10@stanley.mountain/
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Suggested-by: Quentin Perret <qperret@google.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/cpufreq/cppc_cpufreq.c