]> www.infradead.org Git - users/dwmw2/linux.git/commit
genksyms: fix memory leak when the same symbol is read from *.symref file
authorMasahiro Yamada <masahiroy@kernel.org>
Fri, 3 Jan 2025 07:30:39 +0000 (16:30 +0900)
committerMasahiro Yamada <masahiroy@kernel.org>
Fri, 10 Jan 2025 14:01:22 +0000 (23:01 +0900)
commitbe2fa44b5180a1f021efb40c55fdf63c249c3209
tree488b31c6af3c587c80db6ac2390fb4c10e8776a5
parent45c9c4101d3d2fdfa00852274bbebba65fcc3cf2
genksyms: fix memory leak when the same symbol is read from *.symref file

When a symbol that is already registered is read again from *.symref
file, __add_symbol() removes the previous one from the hash table without
freeing it.

[Test Case]

  $ cat foo.c
  #include <linux/export.h>
  void foo(void);
  void foo(void) {}
  EXPORT_SYMBOL(foo);

  $ cat foo.symref
  foo void foo ( void )
  foo void foo ( void )

When a symbol is removed from the hash table, it must be freed along
with its ->name and ->defn members. However, sym->name cannot be freed
because it is sometimes shared with node->string, but not always. If
sym->name and node->string share the same memory, free(sym->name) could
lead to a double-free bug.

To resolve this issue, always assign a strdup'ed string to sym->name.

Fixes: 64e6c1e12372 ("genksyms: track symbol checksum changes")
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
scripts/genksyms/genksyms.c
scripts/genksyms/genksyms.h
scripts/genksyms/parse.y