]> www.infradead.org Git - users/jedix/linux-maple.git/commit
smb3: Do not send SMB3 SET_INFO if nothing changed
authorSteve French <stfrench@microsoft.com>
Fri, 3 Aug 2018 01:28:18 +0000 (20:28 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Sep 2018 07:26:33 +0000 (09:26 +0200)
commitbe1210c7758cb0aba9c4323fb2fe79e64568db77
tree4c4feadfc25a2f68b21285a35747f4342b22375e
parent82a856f527334ffd69aae26e7dd9e03b19c4a520
smb3: Do not send SMB3 SET_INFO if nothing changed

commit fd09b7d3b352105f08b8e02f7afecf7e816380ef upstream.

An earlier commit had a typo which prevented the
optimization from working:

commit 18dd8e1a65dd ("Do not send SMB3 SET_INFO request if nothing is changing")

Thank you to Metze for noticing this.  Also clear a
reserved field in the FILE_BASIC_INFO struct we send
that should be zero (all the other fields in that
struct were set or cleared explicitly already in
cifs_set_file_info).

Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
CC: Stable <stable@vger.kernel.org> # 4.9.x+
Reported-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/cifs/inode.c
fs/cifs/smb2inode.c