]> www.infradead.org Git - users/jedix/linux-maple.git/commit
tmpfs: fix regression hang in fallocate undo
authorHugh Dickins <hughd@google.com>
Sun, 10 Jul 2016 23:46:32 +0000 (16:46 -0700)
committerDhaval Giani <dhaval.giani@oracle.com>
Fri, 20 Jan 2017 22:22:04 +0000 (17:22 -0500)
commitbd9d3ba50a4cfb87eef4d6a9823c4494c7fd18cb
treedb08d72caceafc5771ae4dc046d14f0bfaa86b69
parent9399b48890d94eea3d6b390eea1017d70efe3d05
tmpfs: fix regression hang in fallocate undo

Orabug: 25308092

[ Upstream commit 7f556567036cb7f89aabe2f0954b08566b4efb53 ]

The well-spotted fallocate undo fix is good in most cases, but not when
fallocate failed on the very first page.  index 0 then passes lend -1
to shmem_undo_range(), and that has two bad effects: (a) that it will
undo every fallocation throughout the file, unrestricted by the current
range; but more importantly (b) it can cause the undo to hang, because
lend -1 is treated as truncation, which makes it keep on retrying until
every page has gone, but those already fully instantiated will never go
away.  Big thank you to xfstests generic/269 which demonstrates this.

Fixes: b9b4bb26af01 ("tmpfs: don't undo fallocate past its last page")
Cc: stable@vger.kernel.org
Signed-off-by: Hugh Dickins <hughd@google.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
(cherry picked from commit 116c75f642ad4a6d267f399c9f1fe8b91fb822c5)
Signed-off-by: Dhaval Giani <dhaval.giani@oracle.com>
mm/shmem.c