]> www.infradead.org Git - users/dwmw2/qemu.git/commit
hw/i386/acpi-build: Remove build-time assertion on PIIX/ICH9 reset registers being...
authorBernhard Beschow <shentey@gmail.com>
Wed, 4 Oct 2023 09:23:55 +0000 (11:23 +0200)
committerMichael S. Tsirkin <mst@redhat.com>
Sun, 22 Oct 2023 09:18:16 +0000 (05:18 -0400)
commitbd7a6d88ec900a9a2c5b3ef09f941558908d3cda
tree341e50d5e951f66d4a16fdc9bf5a345a012cb2cb
parentc0c4f147291f37765a5275aa24c3e1195468903b
hw/i386/acpi-build: Remove build-time assertion on PIIX/ICH9 reset registers being identical

Commit 6103451aeb74 ("hw/i386: Build-time assertion on pc/q35 reset register
being identical.") introduced a build-time check where the addresses of the
reset registers are expected to be equal. Back then rev3 of the FADT was used
which required the reset register to be populated and there was common code.
In commit 3a3fcc75f92a ("pc: acpi: force FADT rev1 for 440fx based machine
types") the FADT was downgraded to rev1 for PIIX where the reset register isn't
available. Thus, there is no need for the assertion any longer, so remove it.

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20231004092355.12929-1-shentey@gmail.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/i386/acpi-build.c