]> www.infradead.org Git - nvme.git/commit
scsi: sd: Fix sshdr use in read_capacity_16
authorMike Christie <michael.christie@oracle.com>
Wed, 4 Oct 2023 21:00:02 +0000 (16:00 -0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 13 Oct 2023 20:36:19 +0000 (16:36 -0400)
commitbd593bd2c1e639ba3d42080911f30c1d86875fcc
tree2afd53b4817f861ba1cfb4b7d1221c151bf8a90b
parent0bb80ecc33a8fb5a682236443c1e740d5c917d1d
scsi: sd: Fix sshdr use in read_capacity_16

If scsi_execute_cmd returns < 0, it doesn't initialize the sshdr, so we
shouldn't access the sshdr. If it returns 0, then the cmd executed
successfully, so there is no need to check the sshdr. This has us access
the sshdr when we get a return value > 0.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
Link: https://lore.kernel.org/r/20231004210013.5601-2-michael.christie@oracle.com
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: John Garry <john.g.garry@oracle.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Martin Wilck <mwilck@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/sd.c