]> www.infradead.org Git - users/dwmw2/linux.git/commit
rfs: annotate lockless accesses to RFS sock flow table
authorEric Dumazet <edumazet@google.com>
Tue, 6 Jun 2023 07:41:15 +0000 (07:41 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Jun 2023 09:16:50 +0000 (11:16 +0200)
commitbced76c83b231e610e59fc7331db6ac30ae9bdcb
treefad1a9ad3b8cb153b24740f056984144a3654557
parentcf7436ec9d18a3a3cab187ffb8ee5db6d3e9d778
rfs: annotate lockless accesses to RFS sock flow table

[ Upstream commit 5c3b74a92aa285a3df722bf6329ba7ccf70346d6 ]

Add READ_ONCE()/WRITE_ONCE() on accesses to the sock flow table.

This also prevents a (smart ?) compiler to remove the condition in:

if (table->ents[index] != newval)
        table->ents[index] = newval;

We need the condition to avoid dirtying a shared cache line.

Fixes: fec5e652e58f ("rfs: Receive Flow Steering")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
include/linux/netdevice.h
net/core/dev.c