]> www.infradead.org Git - nvme.git/commit
ubifs: Fix uninitialized use of err in ubifs_jnl_write_inode()
authorNathan Chancellor <nathan@kernel.org>
Fri, 15 Nov 2024 16:10:04 +0000 (09:10 -0700)
committerRichard Weinberger <richard@nod.at>
Fri, 15 Nov 2024 16:45:25 +0000 (17:45 +0100)
commitbcdcb115eaed5e988cf37cc9a1dd5f5dd200e927
tree7abd2c35c845555766d30451a88cf5c9997ed219
parentfe051552f5078fa02d593847529a3884305a6ffe
ubifs: Fix uninitialized use of err in ubifs_jnl_write_inode()

Clang warns (or errors with CONFIG_WERROR=y):

  fs/ubifs/journal.c:986:20: error: variable 'err' is uninitialized when used here [-Werror,-Wuninitialized]
    986 |                 ubifs_ro_mode(c, err);
        |                                  ^~~

Set err to -EPERM before the call to ubifs_ro_mode() and reuse it in the
return statement to resolve the warning.

Fixes: 957e1c4e1779 ("ubifs: ubifs_jnl_write_inode: Only check once for the limitation of xattr count")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Richard Weinberger <richard@nod.at>
fs/ubifs/journal.c