]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/panel: simple: Add a comment about unprepare+disable at shutdown/remove
authorDouglas Anderson <dianders@chromium.org>
Fri, 3 May 2024 21:33:08 +0000 (14:33 -0700)
committerDouglas Anderson <dianders@chromium.org>
Tue, 28 May 2024 20:09:11 +0000 (13:09 -0700)
commitbc62654df3c888dec735343f5db9907ac93aea60
tree9443d701ba6ad9ed8fb54c039c6605ce85b77380
parent2a1c99d7159b798288bfb20a76c1e665e2344126
drm/panel: simple: Add a comment about unprepare+disable at shutdown/remove

It's the responsibility of a correctly written DRM modeset driver to
call drm_atomic_helper_shutdown() at shutdown time and that should be
disabling / unpreparing the panel if needed. Panel drivers shouldn't
be calling these functions themselves.

A recent effort was made to fix as many DRM modeset drivers as
possible [1] [2] [3] and most drivers are fixed now.

Unfortunately, it's very difficult to know exactly which DRM modeset
drivers are using panel-simple due to the sheer number of panels it
handles. For now, we'll leave the calls and just add a comment to keep
people from copying this code.

[1] https://lore.kernel.org/r/20230901234015.566018-1-dianders@chromium.org
[2] https://lore.kernel.org/r/20230901234202.566951-1-dianders@chromium.org
[3] https://lore.kernel.org/r/20230921192749.1542462-1-dianders@chromium.org

Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240503143327.RFT.v2.27.I639183ac987e139092491a94e22d46a5d857580c@changeid
drivers/gpu/drm/panel/panel-simple.c