]> www.infradead.org Git - nvme.git/commit
Revert "PCI: Avoid reset when disabled via sysfs"
authorAlex Williamson <alex.williamson@redhat.com>
Mon, 14 Apr 2025 21:18:23 +0000 (15:18 -0600)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 15 Apr 2025 22:27:40 +0000 (17:27 -0500)
commitbc0b828ef6e561081ebc4c758d0c4d166bb9829c
treec4055e6408d9b0d9f6e6778a479f53a61631fd64
parent0af2f6be1b4281385b618cb86ad946eded089ac8
Revert "PCI: Avoid reset when disabled via sysfs"

This reverts commit 479380efe1625e251008d24b2810283db60d6fcd.

The reset_method attribute on a PCI device is only intended to manage the
availability of function scoped resets for a device.  It was never intended
to restrict resets targeting the bus or slot.

In introducing a restriction that each device must support function level
reset by testing pci_reset_supported(), we essentially create a catch-22,
that a device must have a function scope reset in order to support bus/slot
reset, when we use bus/slot reset to effect a reset of a device that does
not support a function scoped reset, especially multi-function devices.

This breaks the majority of uses cases where vfio-pci uses bus/slot resets
to manage multifunction devices that do not support function scoped resets.

Fixes: 479380efe162 ("PCI: Avoid reset when disabled via sysfs")
Reported-by: Cal Peake <cp@absolutedigital.net>
Closes: https://lore.kernel.org/all/808e1111-27b7-f35b-6d5c-5b275e73677b@absolutedigital.net
Reported-by: Athul Krishna <athul.krishna.kr@protonmail.com>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220010
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Cc: stable@vger.kernel.org
Link: https://patch.msgid.link/20250414211828.3530741-1-alex.williamson@redhat.com
drivers/pci/pci.c