]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/nouveau: Fix WARN_ON in nouveau_fence_context_kill()
authorPhilipp Stanner <phasta@kernel.org>
Tue, 15 Apr 2025 12:19:00 +0000 (14:19 +0200)
committerDanilo Krummrich <dakr@kernel.org>
Wed, 23 Apr 2025 15:38:25 +0000 (17:38 +0200)
commitbbe5679f30d7690a9b6838a583b9690ea73fe0e9
tree0d4fe2292387e92f62c1f2366baefc185f0a56ed
parent095c8e61f4c71cd4630ee11a82e82cc341b38464
drm/nouveau: Fix WARN_ON in nouveau_fence_context_kill()

Nouveau is mostly designed in a way that it's expected that fences only
ever get signaled through nouveau_fence_signal(). However, in at least
one other place, nouveau_fence_done(), can signal fences, too. If that
happens (race) a signaled fence remains in the pending list for a while,
until it gets removed by nouveau_fence_update().

Should nouveau_fence_context_kill() run in the meantime, this would be
a bug because the function would attempt to set an error code on an
already signaled fence.

Have nouveau_fence_context_kill() check for a fence being signaled.

Cc: stable@vger.kernel.org # v5.10+
Fixes: ea13e5abf807 ("drm/nouveau: signal pending fences when channel has been killed")
Suggested-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Philipp Stanner <phasta@kernel.org>
Link: https://lore.kernel.org/r/20250415121900.55719-3-phasta@kernel.org
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
drivers/gpu/drm/nouveau/nouveau_fence.c