]> www.infradead.org Git - users/jedix/linux-maple.git/commit
selftests/vDSO: remove partially duplicated "all:" target in Makefile
authorJohn Hubbard <jhubbard@nvidia.com>
Fri, 5 Jul 2024 19:57:35 +0000 (09:57 -1000)
committerShuah Khan <skhan@linuxfoundation.org>
Fri, 5 Jul 2024 20:12:28 +0000 (14:12 -0600)
commitbb2a605de3757ec8c39e5706cfac3deed5694228
treef21a79c92508196f70fd7e0333e45f994bf05746
parent73810cd45b99c6c418e1c6a487b52c1e74edb20d
selftests/vDSO: remove partially duplicated "all:" target in Makefile

There were a couple of errors here:

1. TEST_GEN_PROGS was incorrectly prepending $(OUTPUT) to each program
to be built. However, lib.mk already does that because it assumes "bare"
program names are passed in, so this ended up creating
$(OUTPUT)/$(OUTPUT)/file.c, which of course won't work as intended.

2. lib.mk was included before TEST_GEN_PROGS was set, which led to
lib.mk's "all:" target not seeing anything to rebuild.

So nothing worked, which caused the author to force things by creating
an "all:" target locally--while still including ../lib.mk.

Fix all of this by including ../lib.mk at the right place, and removing
the $(OUTPUT) prefix to the programs to be built, and removing the
duplicate "all:" target.

Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
tools/testing/selftests/vDSO/Makefile