]> www.infradead.org Git - users/jedix/linux-maple.git/commit
platform/x86/amd/pmc: Fix SMU command submission path on new AMD platform
authorShyam Sundar S K <Shyam-sundar.S-k@amd.com>
Thu, 22 Aug 2024 09:53:56 +0000 (15:23 +0530)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Fri, 23 Aug 2024 13:13:04 +0000 (16:13 +0300)
commitba7b6633e9afa6b5a788efd533c4bdc6fb1c606d
treee125920c3d61674589f2b7e9a1b5591b3740cf58
parent46ee21e9f59205e54943dfe51b2dc8a9352ca37d
platform/x86/amd/pmc: Fix SMU command submission path on new AMD platform

The commit 426463d94d45 ("platform/x86/amd/pmc: Send OS_HINT command for
new AMD platform") was introduced to enable sending mailbox commands to
PMFW on newer platforms. However, it was later discovered that the commit
did not configure the correct message port ID (i.e., S2D or PMC). Without
this configuration, all command submissions to PMFW are treated as
invalid, leading to command failures.

To address this issue, the CPU ID association for the new platform needs
to be added in amd_pmc_get_ip_info(). This ensures that the correct SMU
port IDs are selected.

Fixes: 426463d94d45 ("platform/x86/amd/pmc: Send OS_HINT command for new AMD platform")
Co-developed-by: Sanket Goswami <Sanket.Goswami@amd.com>
Signed-off-by: Sanket Goswami <Sanket.Goswami@amd.com>
Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20240822095357.395808-1-Shyam-sundar.S-k@amd.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/amd/pmc/pmc.c