]> www.infradead.org Git - users/jedix/linux-maple.git/commit
RAID5: check_reshape() shouldn't call mddev_suspend
authorShaohua Li <shli@fb.com>
Thu, 25 Feb 2016 01:38:28 +0000 (17:38 -0800)
committerChuck Anderson <chuck.anderson@oracle.com>
Thu, 26 May 2016 22:46:10 +0000 (15:46 -0700)
commitba6f3a3d71aef3505976c3120040a8686889c701
tree378d3030ae7b59420bb9e5b3f112d67577f29f72
parentb0b4f9bfd9ddf51f0ede82ee79716ecaed2b769d
RAID5: check_reshape() shouldn't call mddev_suspend

Orabug: 23331070

[ Upstream commit 27a353c026a879a1001e5eac4bda75b16262c44a ]

check_reshape() is called from raid5d thread. raid5d thread shouldn't
call mddev_suspend(), because mddev_suspend() waits for all IO finish
but IO is handled in raid5d thread, we could easily deadlock here.

This issue is introduced by
738a273 ("md/raid5: fix allocation of 'scribble' array.")

Cc: stable@vger.kernel.org (v4.1+)
Reported-and-tested-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Reviewed-by: NeilBrown <neilb@suse.com>
Signed-off-by: Shaohua Li <shli@fb.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
(cherry picked from commit 503f8305ab1b82d8788a2f161e7c52c0c0f6aeac)

Signed-off-by: Dan Duval <dan.duval@oracle.com>
drivers/md/raid5.c
drivers/md/raid5.h