]> www.infradead.org Git - users/hch/block.git/commit
kbuild: rpm-pkg: Fix C locale setup
authorPetr Vorel <pvorel@suse.cz>
Wed, 24 Jul 2024 08:46:55 +0000 (10:46 +0200)
committerMasahiro Yamada <masahiroy@kernel.org>
Wed, 24 Jul 2024 10:26:44 +0000 (19:26 +0900)
commitba6c664081afd18da86ac49cb22ceb266f89a561
treefeffcc207807c6eb149534780f80f8e0f52a5fc0
parent5ad7ff8738b8bd238ca899df08badb1f61bcc39e
kbuild: rpm-pkg: Fix C locale setup

semicolon separation in LC_ALL is wrong. Either variable needs to be
exported before as a separate commit or set as part of the commit in the
beginning. Used second variant.

This fixes broken build on user's locale setup which makes 'date' binary
to produce invalid characters in rpm changelog (e.g. cs_CZ.UTF-8 'čec'):

$ make binrpm-pkg
  GEN     rpmbuild/SPECS/kernel.spec
rpmbuild -bb rpmbuild/SPECS/kernel.spec --define='_topdirlinux/rpmbuild' \
    --target x86_64-linux --build-in-place --noprep --define='_smp_mflags \
    %{nil}' $(rpm -q rpm >/dev/null 2>&1 || echo --nodeps)
Building target platforms: x86_64-linux
Building for target x86_64-linux
error: bad date in %changelog: St čec 24 2024 user <user@somehost>
make[2]: *** [scripts/Makefile.package:71: binrpm-pkg] Error 1
make[1]: *** [linux/Makefile:1546: binrpm-pkg] Error 2
make: *** [Makefile:224: __sub-make] Error 2

Fixes: 301c10908e42 ("kbuild: rpm-pkg: introduce a simple changelog section for kernel.spec")
Signed-off-by: Petr Vorel <pvorel@suse.cz>
Reviewed-by: Miguel Ojeda <ojeda@kernel.org>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
scripts/package/mkspec